FIX Update HTML markup for bootstrap 5 #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/6.0/upgrade-bootstrap
branch
from
8689f17 to
fa0cb81
Compare
GuySartorelli
force-pushed
the
pulls/6.0/upgrade-bootstrap
branch
from
fa0cb81 to
545c1aa
Compare
GuySartorelli
commented
Jan 23, 2025
| @@ -5,9 +5,7 @@ | |||
| <% if $ImportModalTitle %> | |||
| <h2 class="modal-title">$ImportModalTitle</h2> | |||
| <% end_if %> | |||
| <button type="button" class="close" data-dismiss="modal" aria-label="Close"> | |||
| <span aria-hidden="true">×</span> | |||
There was a problem hiding this comment.
The x span was causing two different x to be rendered.
emteknetnz
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1889 which links to the specific upgrade guide entries for most changes made.
Issue