Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Support Storybook v7 #244

Merged

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented May 24, 2023

Description

Updates for @storybook/addon-knobs to support Storybook v7:

  • Replaced storiesOf API with CSF(Component Story Format). See notice;

Parent issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the UPD prefix on the commit and pull-request to MNT instead - https://docs.silverstripe.org/en/5/contributing/code/#commit-messages

package.json Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/3/storybook-update branch from 7452d36 to d61d5a6 Compare May 30, 2023 20:52
@sabina-talipova sabina-talipova changed the title UPD Support Storybook v7 MNT Support Storybook v7 May 30, 2023
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll create a separate card to deal with the 4 space indent which should be a 2 space indent

@emteknetnz emteknetnz merged commit 47f86a6 into silverstripe:3 May 30, 2023
@emteknetnz emteknetnz deleted the pulls/3/storybook-update branch May 30, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants