Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Require tagged version of silverstripe/supported-modules #39

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 12, 2025

Issue silverstripe/.github#365

We need to use a tagged version of supported-modules in order to get the ^1.2 line of tx-translator to install on a CMS 5 site, otherwise it will be limited to the 1.1 line

@emteknetnz emteknetnz marked this pull request as ready for review February 12, 2025 21:07
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit c8002b1 into silverstripe:1 Feb 13, 2025
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1/supported-modules branch February 13, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants