-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and optimise creation of DataCurve
geometries
#1393
Conversation
I'm surprised that the CI passes since error bars are now rendered for error values equal to 0, but I guess we don't take snapshots of line visualizations with points only, so the error bar in the snapshot we do take must merge seemlessly with the curve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not convinced either by the hooks.
But let's move forward with this see how it goes with future refactorings.
/approve |
Update Cypress reference snapshots
Follows #1390
I'm refactoring
DataCurve
like I did withScatterPoints
. Here's what changes concretely in this PR:(0, 0, CAMERA_FAR)
trick).ErrorBars
regardless of whethershowErrors
is enabled or disabled. TheshowErrors
condition is now part of thevisible
condition of the Three objects involved in rendering the error bars and caps. I think it's better to have a bit more work in the main loop even when errors are toggled off, than to run a full second loop when the errors are toggled on. Note however that like before, if a dataset doesn't haveerrors
, the error geometries are never created.