Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debounce on dimension mapping state to reduce lag #1634

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented May 3, 2024

Baby step to address #1578

  1. We first added debouncing on the dimension mapping state in Debounce dim mapping state to reduce fetching rate when slicing #888 to address [DimensionMapper] Be less eager to fetch when slicing #879.
  2. In [DimensionMapper] Review debouncing of dim mapping state #920, we then realised that this also debounced the axis mappers (the D0/D1/.../Dn button groups), so we opened Debounce slicing without affecting UI responsiveness #975 with the goal of moving the debounce to the sliders.
  3. Turns out that in that PR, we added debouncing to the sliders without actually removing it on the dimension mapping state... So we ended up with two debounces, for a total of 350 ms.

In this PR, I therefore remove the debounce on the dimension mapping state, thus saving 100ms both when slicing and changing axis dimensions.

Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Well spotted 👍

@axelboc axelboc merged commit 78e1dda into main May 6, 2024
8 checks passed
@axelboc axelboc deleted the remove-deb branch May 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants