Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support complex auxiliaries #1676

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Support complex auxiliaries #1676

merged 2 commits into from
Jun 24, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jun 20, 2024

Fix #1670

image

@axelboc axelboc requested review from loichuder and removed request for loichuder June 20, 2024 07:53
@axelboc axelboc force-pushed the complex-auxiliaries branch 2 times, most recently from 450d14c to 3a76b3f Compare June 20, 2024 08:07
@axelboc
Copy link
Contributor Author

axelboc commented Jun 20, 2024

/approve

@axelboc axelboc requested a review from loichuder June 20, 2024 08:18
loichuder
loichuder approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

Do you intend to also add supports of aux for NxComplexImage ? You already made more than half of the way there.

@axelboc axelboc force-pushed the complex-auxiliaries branch from 849d5c8 to 03453f9 Compare June 24, 2024 06:45
@axelboc
Copy link
Contributor Author

axelboc commented Jun 24, 2024

Do you intend to also add supports of aux for NxComplexImage ? You already made more than half of the way there.

Yeah, might as well

@axelboc axelboc merged commit 5ede8e3 into main Jun 24, 2024
8 checks passed
@axelboc axelboc deleted the complex-auxiliaries branch June 24, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complex auxiliary signals
2 participants
@axelboc @loichuder