Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch partials folder during build #8

Closed
andig opened this issue Aug 30, 2018 · 6 comments
Closed

Watch partials folder during build #8

andig opened this issue Aug 30, 2018 · 6 comments

Comments

@andig
Copy link
Collaborator

andig commented Aug 30, 2018

Currently doesn't seem to be the case. I also have the problem in another plugin- using your webpack setup- the config partial is not loaded (and no error message).

@andig
Copy link
Collaborator Author

andig commented Aug 30, 2018

Also, build setup doesn't allow css imports yet:

import './css/query-editor.css!'

gives parsing error

@simPod
Copy link
Owner

simPod commented Aug 31, 2018

It looks like they are

image

How can I reproduce?

Also, there seem to be a test for

{
        test: /\.css$/,`

Your extension is .css!, not sure what ! means but it doesn't match the pattern cuz of it.

@simPod simPod mentioned this issue Aug 31, 2018
@andig
Copy link
Collaborator Author

andig commented Sep 1, 2018

I will recheck the css. Partials build is working, but they don‘t appear to be watched opposed to ts files?

@andig
Copy link
Collaborator Author

andig commented Sep 1, 2018

Btw, I just tried to publicize my Darksky plugin (grafana/grafana-plugin-repository#301). Once I can see that works- shall we start publishing this datasource?

@simPod
Copy link
Owner

simPod commented Oct 4, 2018

Sure. I think there's a bug in sending those global variables. My backend sometimes receives $__all. Have to look into it.

@andig
Copy link
Collaborator Author

andig commented Oct 4, 2018

Ok, then lets wait until that bug is fixed. Publishing at Grafana is painful :/

simPod added a commit that referenced this issue Nov 16, 2018
@andig andig closed this as completed in #20 Nov 16, 2018
andig pushed a commit that referenced this issue Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants