Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables the icelake kernel when building with Visual Studio 2019. #328

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

lemire
Copy link
Member

@lemire lemire commented Oct 8, 2023

This patch disables the icelake kernel when building with Visual Studio 2019.

@deepak1556 demonstrated an issue that we reproduce solely with Visual Studio 2019 (not Visual Studio 2022) when transcoding from UTF-16 to UTF-8 using AVX-512 routines. It seems possible that the AVX-512 support in Visual Studio 2019 is faulty.

Fixes #329

@lemire lemire changed the title Adding test for Visual Studio 2019 issue in node Disables the icelake kernel when building with Visual Studio 2019. Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disabling the icelake kernel for Visual Studio 2019
1 participant