Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using with typescript #51

Closed
bpiasecki opened this issue Mar 31, 2020 · 8 comments
Closed

using with typescript #51

bpiasecki opened this issue Mar 31, 2020 · 8 comments

Comments

@bpiasecki
Copy link

What i'm trying to do is to import this package into Angular 8 project with Typescript. Unfortunatelly im getting errors "i is not defined" or "round is not defined", both of variables in all use cases are not declared in source code.
Please fix it by adding 'var' keyword before every 'i' in loops and before round object declaration

@simogeo
Copy link
Owner

simogeo commented Apr 3, 2020

thanks for reporting @bpiasecki, I'll try to fix this today and I ask you to do some tests

simogeo pushed a commit that referenced this issue Apr 3, 2020
@simogeo
Copy link
Owner

simogeo commented Apr 3, 2020

Can you please test now and let me know ?

@bpiasecki
Copy link
Author

bpiasecki commented Apr 3, 2020

Thanks for fast response :) I can't run app right now but i can see that there're still missing declarations of 'datalist' objects in getClassJenks and getClassJenks2. After that everything should be fine, I tested it before with local changes of these declarations

BTW, awesome work with this library!

@simogeo
Copy link
Owner

simogeo commented Apr 3, 2020

Thanks !

Here we go : 504316a

@simogeo simogeo closed this as completed Apr 3, 2020
@hawklorry
Copy link

Is this version published on npm yet? It seems the latest version is still 1.8.0. I encounter same issue in my Angular application.

@simogeo
Copy link
Owner

simogeo commented Apr 13, 2020

@hawklorry : Should be ok, now !

@hawklorry
Copy link

It works. Thanks for the quick response.

@simogeo
Copy link
Owner

simogeo commented Apr 14, 2020

My pleasure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants