fix(250): allow using refetch in children components #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 77.31% 78.84% +1.52%
==========================================
Files 2 2
Lines 97 104 +7
Branches 14 15 +1
==========================================
+ Hits 75 82 +7
Misses 21 21
Partials 1 1
Continue to review full report at Codecov.
|
simoneb
force-pushed
the
fix/250/refetch-in-children-components
branch
7 times, most recently
from
a0a2f11 to
d80067b
Compare
fixes #250 This will make it possible to pass the refetch function down to children component and let them invoke it, without erroring on a missing token. New behavior: cancelation errors are thrown for requests generated by the `refetch` function. This is more consistent with how response and other errors are returned when fetching manually.
simoneb
force-pushed
the
fix/250/refetch-in-children-components
branch
from
d80067b to
0de127e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250 by using useLayoutEffect instead of useEffect