feat: apply type-safe for AxiosRequestConfig data parameter #611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 2 2
Lines 137 137
Branches 25 25
=======================================
Hits 136 136
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Overall looks good, see inline comments.
This will need to be a semver major as this is a breaking change but don't bump the version in this PR please.
In the upstream PR axios/axios#4116 I see that also the AxiosError type got a new generic parameter, shall we include that as well?
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "axios-hooks", | |||
| "version": "2.7.0", | |||
| "version": "2.7.1", | |||
There was a problem hiding this comment.
do not bump the version please, it will be done at the time of release
|
I've updated the pr, thanks for the comment. |
simoneb
changed the title
Closes #610
BREAKING CHANGE: requires axios@^0.24.0