Drop xvfb-maybe

simonw · Jul 12, 2022 · 3ace80f · 3ace80f · simonw · Jul 12, 2022
1 parent 10ccbe6
commit 3ace80f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 86 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -31,14 +31,10 @@ jobs:
         run: |
           ./download-python.sh
       - name: Run tests
-        run: npx xvfb-maybe -- npm test
+        run: npm test
         timeout-minutes: 5
-      - name: tmate on failure
-        uses: mxschmitt/action-tmate@v3
-        if: failure()
-      - name: Upload video if tests failed
+      - name: Upload test videos
         uses: actions/upload-artifact@v3
-        if: failure()
         with:
           name: test-videos
           path: test-videos/

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -58,8 +58,7 @@
     "electron": "^19.0.8",
     "electron-builder": "^22.11.7",
     "electron-notarize": "^1.1.1",
-    "playwright": "^1.23.2",
-    "xvfb-maybe": "^0.2.1"
+    "playwright": "^1.23.2"
   },
   "dependencies": {
     "electron-prompt": "^1.6.2",