Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete DEFAULT_EMBEDDING_MODEL code #537

Closed
simonw opened this issue Jul 18, 2024 · 0 comments
Closed

Remove obsolete DEFAULT_EMBEDDING_MODEL code #537

simonw opened this issue Jul 18, 2024 · 0 comments
Labels
embeddings enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Jul 18, 2024

It's cheaper and better than ada-002.

llm/llm/cli.py

Line 45 in fcba89d

DEFAULT_EMBEDDING_MODEL = "ada-002"

UPDATE: I thought I needed to update this to 3-small but it turns out that code does nothing:

You can omit the `-m/--model` option if you set a {ref}`default embedding model <embeddings-cli-embed-models-default>`.

@simonw simonw added enhancement New feature or request embeddings labels Jul 18, 2024
@simonw simonw changed the title Default embedding model should be 3-small Remove obsolete DEFAULT_EMBEDDING_MODEL code Jul 18, 2024
@simonw simonw closed this as completed in 0ef5037 Jul 18, 2024
simonw added a commit that referenced this issue Jul 18, 2024
simonw added a commit that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embeddings enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant