Add changeSource parameter to instance object passed on 'change' event. #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue.
The 'change' event coming from the preview fires many times per second. This doesn't allow to add an event listener that takes long to run >30ms, otherwise the preview gets blocked. So any heavy calculation has to go to 'changestop' event and only light calculations on 'change'.
The problem is that 'changestop' won't fire from the input, so I cannot fire any heavy calculation when the user changes the input.
Adding extra events like
'inputChange'
,'previewChange'
or'swatchChange'
feels like duplicating functionality.Adding an extra parameter to the event callback will break things since it will look like
(color, changeSource, instance)
and the instance parameter would change from the second to the third position.So the fastest and non-breaking solution was adding an extra property to
pickr
I also changed the dev url to the current one.
localhost:8080
doesn't work anymore.