Some UX changes to make it clearer what mode user is in and faster to get back to editing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @simonxeko, lovely extension, works really well. I made a couple of UX tweaks for personal use, which you might want to consider merging if you like them.
A quick preview below:
In summary, the modifications do the following:
They allow you to dismiss the preview when clicking on the actual preview box, which takes you back to the composer with the cursor focused where you had left off. This seems like it would be more natural and expected behaviour, since users might find themselves wanting to edit the preview and click on text they would expect to be editable. (the preview button also focuses the composer input element now, which is a bit smoother for workflow).
The preview button is now highlighted with the Button--danger style (red in the default template), to make it very obvious that the preview is currently active to avoid some potential confusion for users. I found it wasn't necessarily clear for less technical users, whether it was wysiwyg or a passive preview.
Along the above lines, while in preview mode, a grey 'eye' icon from font-awesome is rendered as a watermark behind the preview window. I tested this on mobile and desktop and it seemed fine, but your mileage may vary on whether you like this. I found it a useful secondary indicator that the text was an uneditable preview.
Do please let me know if any queries or feedback.
Ps.: Am a bit new to github, so I just saw the webpack dependency upgrade in composer.json - sorry, that should not have been included.