Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when no domain is set #222

Closed
silug opened this issue Dec 17, 2024 · 0 comments · Fixed by #223
Closed

Error when no domain is set #222

silug opened this issue Dec 17, 2024 · 0 comments · Fixed by #223

Comments

@silug
Copy link
Contributor

silug commented Dec 17, 2024

On a node with no domain, fact_on(sut, 'networking.domain') returns nil. This will break the following two lines:

lib/simp/beaker_helpers.rb:726:      current_domain = fact_on(sut, 'networking.domain').strip
lib/simp/beaker_helpers.rb:747:      if fact_on(sut, 'networking.domain').strip.empty?

This results in the following error:

Failure/Error: fix_errata_on(hosts)
NoMethodError:
  undefined method `strip' for nil
  
# ./vendor/ruby/3.3.0/gems/simp-beaker-helpers-1.34.0/lib/simp/beaker_helpers.rb:726:in `block in linux_errata'
@op-ct op-ct added this to Org Triage Dec 17, 2024
silug added a commit to silug/rubygem-simp-beaker-helpers that referenced this issue Dec 17, 2024
@silug
Fix error when no domain is set
372e202 
Fixes simp#222
@silug silug mentioned this issue Dec 17, 2024
Merged
rgardner4012 pushed a commit that referenced this issue Dec 17, 2024
@silug
Fix error when no domain is set (#223)
1434ced 
Fixes #222
@github-project-automation github-project-automation bot moved this from New to Done in Org Triage Dec 17, 2024
@silug silug mentioned this issue Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Org Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error when no domain is set silug/rubygem-simp-beaker-helpers
1 participant
@silug