Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quasi-static-patch #58

Merged
merged 1 commit into from
Jun 8, 2023
Merged

quasi-static-patch #58

merged 1 commit into from
Jun 8, 2023

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented May 31, 2023

allow epsilon to be set to zero as a valid way to invoke the quasi-static assumption

@lheagy lheagy requested a review from jcapriot May 31, 2023 17:20
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #58 (926d746) into main (aca90d1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files          29       29           
  Lines        3021     3021           
=======================================
  Hits         2654     2654           
  Misses        367      367           
Impacted Files Coverage Δ
geoana/em/base.py 100.00% <100.00%> (ø)

@lheagy
Copy link
Member Author

lheagy commented Jun 8, 2023

👋 @jcapriot: would you mind taking a look at this when you have a chance? It is good to go from my perspective

@jcapriot jcapriot merged commit f8afcb8 into main Jun 8, 2023
@jcapriot jcapriot deleted the quasi-static-patch branch June 8, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants