Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the copy() method instead of copy kwarg #80

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Use the copy() method instead of copy kwarg #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions geoana/spatial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,8 @@ def rotation_matrix_from_normals(v0, v1, tol=1e-20, as_matrix=True):
The rotation matrix from v0 to v1, whose type depends on the `as_matrix` parameter.
"""

v0 = np.asarray(v0, dtype=float, copy=True).squeeze()
v1 = np.asarray(v1, dtype=float, copy=True).squeeze()
v0 = np.asarray(v0, dtype=float).copy().squeeze()
v1 = np.asarray(v1, dtype=float).copy().squeeze()

if v0.shape != (3, ):
raise ValueError(f"v0 shape should be (3,), got {v0.shape}")
Expand Down