Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require path error in examples #43

Merged

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Nov 2, 2021

I'm getting the next error trying to run the examples:

bin/cli.js --config src/rules/examples/elms.js

(x) Failed to parse config: Error: Cannot find module '../lib/logger'
     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
     at Function.Module._load (internal/modules/cjs/loader.js:529:25)
     at Module.require (internal/modules/cjs/loader.js:657:17)
     at require (internal/modules/cjs/helpers.js:22:18)
     at Object.<anonymous> (/home/mondeja/files/code/svglint/src/rules/examples/elms.js:1:78)
     at Module._compile (internal/modules/cjs/loader.js:721:30)
     at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
     at Module.load (internal/modules/cjs/loader.js:620:32)
     at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
     at Function.Module._load (internal/modules/cjs/loader.js:552:3)

Could be in conflict with #41

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @mondeja 👍

I'm getting the next error trying to run the examples

Would you agree this is not urgent?

Could be in conflict with #41

No worries, that'll be an easy fix 🙂

@ericcornelissen ericcornelissen merged commit 5e6c50e into simple-icons:master Nov 2, 2021
@mondeja mondeja deleted the fix-examples-require-path branch November 2, 2021 21:02
@mondeja
Copy link
Member Author

mondeja commented Nov 2, 2021

Of course it is not urgent, at least for me 🙃

@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants