Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking config.rules when config is null #79

Closed
wants to merge 2 commits into from

Conversation

luciansmith
Copy link

Possible fix for #78. Not sure I've used 'hasOwnProperty' correctly, but this at least works for me when there is no user config.

Possible fix for simple-icons#78.  Not sure I've used 'hasOwnProperty' correctly, but this at least works for me when there is no user config.
This means that we will still encounter an error if config isn't null, but doesn't have a 'notes' property, but the linter didn't like figuring it out this way.
@ericcornelissen
Copy link
Contributor

Superseded by #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants