Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

v1.5.8 vCode 49 Pre-release #479

Closed
a-r-db opened this issue Aug 27, 2019 · 37 comments
Closed

v1.5.8 vCode 49 Pre-release #479

a-r-db opened this issue Aug 27, 2019 · 37 comments
Labels
release New Release Pending

Comments

@a-r-db
Copy link
Contributor

a-r-db commented Aug 27, 2019

Pre-Release v3 SLS 1.5.8 vCode 49 pre-v12

As described in the link, the app has gone through some changes.
I need as many people as possible to help debug them for now.

Thanks,
Austin H.

@j-paulus
Copy link

On FireTV (v1), starting the app just flashes a white screen briefly and then it exits.

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 29, 2019

This is a somewhat unusual device for me.
Do you have any additional information?
Also, are you a developer by chance?

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 29, 2019

The main issue with non-standard android products is library dependencies and certain other things.
Did it work before?

@j-paulus
Copy link

I understand the problem of this non-standard device. If the app would work, that would be nice, but if that's too much work, also that is fully understandable.

Working before: Yes. And no. The app loaded, the settings could be adjusted, and relatively long it even scrobbled properly. Until after some OS update (I don't know anymore at which point) the scrobbling stopped. Still, the app didn't crash as the current pre-release does.

I'm not an SW-developer, but more on the algorithmic side. Still, if I can somehow help, I'm happy to do so. Do you have an idea where to look for the logs?

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 29, 2019

Here are some helpful instructions.

  1. Amazon FireTV Debug
  2. SLS Debugging
    Thanks.
    I apologize, I do not have access to Fire TV or these Amazon style Operating Systems.

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 29, 2019

Could you share your Android Operating system version please too?

@j-paulus
Copy link

On the permissions screen, "Notification Listener" is gray, while others are green. With some blind clicking (using a remote doesn't show where the cursor is at) displayed the red hint text about notifications ignore list. Checking the device settings still shows all notifications from SLS being allowed.

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 31, 2019

Sorry it's called "notification access".

@j-paulus
Copy link

Maybe I just didn't find it, but I found no way of controlling the app permissions in this version of FireOS. It can be because it's still based on so old Android API (v22). Instead, all permissions should be presented in the manifest in apk, and I didn't find BIND_NOTIFICATION_LISTENER_SERVICE listed there.

Could this be the issue?

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 31, 2019

Yes, this is exactly the issue unfortunately.
I am researching now.
Lollipop is API 21 so I going to need to put in special code or find out if you device has Notification Listener Service at all.

@a-r-db
Copy link
Contributor Author

a-r-db commented Aug 31, 2019

I am sure you were thorough but did you look here ?

Settings > Sounds & Notifications > Manage notification listeners

@j-paulus
Copy link

j-paulus commented Sep 2, 2019

That doesn't exist on this gen1 device. There are:

  • Settings > Notifications (displays current notifications)
  • Settings > Display & Sound (audio and video settings)
  • Settings > Applications > Manage Installed Applications (launch, force stop, uninstall, clear data, clear cache)
  • Settings > Preferences > Notification Settings (turn on/off Do not disturb, turn on/off notifications from individual apps)

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

It looks like they have removed this possibility of notification reading from their Operating System.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

This means, like I said previously, device specific code and reading the old way for broadcasts.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

I can add a disable notification listener button to the options list if you want?
The downside is that it will miss the new functionality offered.
Unfortunately the new functionality is required to try new music apps and hence Notification Listener.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

@nswint I have your fix in a minute. pre-v11

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

@nswint It's at the top there.

@nswint
Copy link

nswint commented Sep 2, 2019

@nswint It's at the top there.

Thanks. pre-v11 is super broken now

  • I wasn't prompted for the new/updated listener permissions. I reinstalled and saw the requests for the new permissions. (Reinstall gave me a host of new issues with session keys and authentication.)
  • After all 4 permissions are allowed the app automatically continues without out pressing the continue button
  • Last.fm give wrongs username/password/token errors. I've cleared the username and session key.
    I'm using the right username/password
  • Pocketcasts show empty now playing information.
  • Pocketcasts no longer scrobbles
  • Google Play music only scrobbles once and doesn't scrobble any more
  • Settings seem to persist now. Are these saved locally in a folder or in google cloud now?

No scrobble information
Pic

Scrobble from 1.5 songs prior. The song reported 2 minutes prior that it scrobbled but I finished the song 6 minutes prior. I have the setting to submit at 50% of the song so it should have scrobbed about 8 minutes prior.

Pic

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

  • I wasn't prompted for the new/updated listener permissions. I reinstalled and saw the requests for the new permissions. (Reinstall gave me a host of new issues with session keys and authentication.)
    reinstall sometimes affects shared preference keys (aka I cannot change that)
    if you set listener permissions once, you should be ok

  • After all 4 permissions are allowed the app automatically continues without out pressing the continue button is expected behavior

  • Last.fm give wrongs username/password/token errors. I've cleared the username and session key.
    I'm using the right username/password
    Can you share a bit more information? If you're a developer a debug log dump could help me out.

  • Pocketcasts show empty now playing information. this will happen if you are not logged in

  • Pocketcasts no longer scrobbles this will happen if you are not logged in

  • Google Play music only scrobbles once and doesn't scrobble any more something is wrong

  • Settings seem to persist now. Are these saved locally in a folder or in google cloud now? locally

@nswint
Copy link

nswint commented Sep 2, 2019

  • I wasn't prompted for the new/updated listener permissions. I reinstalled and saw the requests for the new permissions. (Reinstall gave me a host of new issues with session keys and authentication.)
    reinstall sometimes affects shared preference keys (aka I cannot change that)
    if you set listener permissions once, you should be ok
  • After all 4 permissions are allowed the app automatically continues without out pressing the continue button is expected behavior
  • Last.fm give wrongs username/password/token errors. I've cleared the username and session key.
    I'm using the right username/password
    Can you share a bit more information? If you're a developer a debug log dump could help me out.
  • Pocketcasts show empty now playing information. this will happen if you are not logged in
  • Pocketcasts no longer scrobbles this will happen if you are not logged in
  • Google Play music only scrobbles once and doesn't scrobble any more something is wrong
  • Settings seem to persist now. Are these saved locally in a folder or in google cloud now? locally

What is an email address that I can mail you the link to the debug log? Debug logs sometimes might contain some passwords and such and the number of bots that comb github for passwords and other credentials probably outnumber living humans.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 2, 2019

[email protected]

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 3, 2019

Ok I worked last night and this morning.
It seems that the notification controller is much more dense than I thought.
I was not issuing access to the media session correctly nor was I registering the callbacks correctly.
After the first callback the whole system fails to recognize the music players.
Apologies for the delay and issues therein.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 3, 2019

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 3, 2019

I might as well restart the one week rule for pre-release.
That will mean waiting until September 9th or 10th until I release the final apk.

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 4, 2019

@nswint Apologies if this question seems crass, yet I wonder if the new release is working well for you?

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 4, 2019

@drjobec I think I need to add a special apk for your device or add a bypass option to the permissions system for legacy operating systems or special operating systems. I will create a new issue.

@a-r-db a-r-db closed this as completed Sep 4, 2019
@j-paulus
Copy link

j-paulus commented Sep 5, 2019

I leave it to your consideration if the extra effort is worth it. Personally, I would appreciate it, but such "old" systems are probably getting already quite rare. The reason I'm still using the Gen1 device is that it's still working, and to date it's the only FireTV with a separate digital audio-out allowing listening to music without the TV being on (without an AVR).
It would be the easiest, if the required permission could be granted somehow automatically during installation, but I know too little of Android apps and permissions to know if this is even possible.
Thanks anyway for your effort!

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 5, 2019

No it's okay. I'll make it happen.
Just give me some time.
Like I said. You can bypass the functionality, but you will need to rely on old broadcasts.
Android before Oreo will work.

@nswint
Copy link

nswint commented Sep 7, 2019 via email

@a-r-db
Copy link
Contributor Author

a-r-db commented Sep 8, 2019

#508 @drjobec

@a-r-db a-r-db reopened this Sep 8, 2019
@a-r-db a-r-db closed this as completed Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release New Release Pending
Projects
None yet
Development

No branches or pull requests

3 participants