Skip to content

Commit

Permalink
not generate code source in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Son NK committed Apr 11, 2024
1 parent ed53943 commit 04eca2b
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 15 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,6 @@ jobs:
# dist-zip/simplelogin-extension-beta-firefox-v... can be submitted to firefox
SUFFIX=firefox npm run build-zip
# create the code source for firefox reviewer
rm -rf code-for-reviewer && mkdir code-for-reviewer
# copy the minimum files
cp -r src LICENSE CHANGELOG scripts package.json package-lock.json webpack.config.js .dev.sample.json .babelrc code-for-reviewer
# override the readme
cp reviewers/firefox-beta.md code-for-reviewer/README.md
- name: Build production version for Firefox
if: matrix.variant == 'beta-firefox'
shell: bash
Expand All @@ -164,13 +156,6 @@ jobs:
# dist-zip/simplelogin-extension-beta-firefox-v... can be submitted to firefox
SUFFIX=firefox npm run build-zip
# create the code source for firefox reviewer
rm -rf code-for-reviewer && mkdir code-for-reviewer
# copy the minimum files
cp -r src LICENSE CHANGELOG scripts package.json package-lock.json webpack.config.js .dev.sample.json .babelrc code-for-reviewer
# override the readme
cp reviewers/firefox.md code-for-reviewer/README.md
- name: Build production version for Chromium
if: matrix.variant == 'full'
shell: bash
Expand Down
30 changes: 30 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,36 @@ npm run prettier:write
4. Wait until the CI process generates the extension ZIP and uploads it to GitHub. You will be able to find the generated zip as an artifact attached to the [GitHub release](https://github.com/simple-login/browser-extension/releases).
5. Upload the extension to the Chrome, Firefox and Edge stores.

### Firefox

For Firefox, the code source must be submitted too. To faciliate the review process, the code source can be generated using the following script

For beta version:

```bash
# create the code source for firefox reviewer
rm -rf code-for-reviewer && mkdir code-for-reviewer
# copy the minimum files
cp -r src LICENSE CHANGELOG scripts package.json package-lock.json webpack.config.js .dev.sample.json .babelrc code-for-reviewer
# override the readme
cp reviewers/firefox-beta.md code-for-reviewer/README.md
```

For prod version

```bash
# create the code source for firefox reviewer
rm -rf code-for-reviewer && mkdir code-for-reviewer
# copy the minimum files
cp -r src LICENSE CHANGELOG scripts package.json package-lock.json webpack.config.js .dev.sample.json .babelrc code-for-reviewer
# override the readme
cp reviewers/firefox.md code-for-reviewer/README.md
```


## How to build the extension locally

Expand Down

0 comments on commit 04eca2b

Please sign in to comment.