New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login with proton to extension #154

Merged

nguyenkims merged 3 commits into master from feature/add-login-with-proton-to-extension

Jun 18, 2022

Collaborator

cquintana92 commented Jun 17, 2022

This PR performs the following changes:

Adds script scripts/generateBuildConfig.js that generates the src/popup/buildConfig.json file, containing information about the build, such as build time, features enabled...
Adds a "Login with Proton" button on the Login page if the buildConfig.features.loginWithProtonEnabled feature is enabled.
Adds call to CI before running the build process for generating the corresponding src/popup/buildConfig.json file.


          Add login with proton to extension

b3f4bbe

cquintana92 requested review from acasajus and nguyenkims as code owners

June 17, 2022 10:45

cquintana92 added 2 commits

June 17, 2022 13:19


          UI tweaks

f1f365e


          Fix hover color

a958250

nguyenkims approved these changes

View reviewed changes

Contributor

nguyenkims left a comment

LGTM!

nguyenkims merged commit 9c78380 into master

cquintana92 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels