Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: non-ASCII characters are broken #91

Closed
Tietew opened this issue Feb 13, 2020 · 3 comments
Closed

Regression: non-ASCII characters are broken #91

Tietew opened this issue Feb 13, 2020 · 3 comments

Comments

@Tietew
Copy link
Contributor

Tietew commented Feb 13, 2020

When a source file includes non-ASCII characters i.e. Hiragana,
generated HTML contains source popups with broken characters.

Source:

MSG = "おはよう"

Expected: (simplecov-html 1.11.0)

1. MSG = "おはよう"

Actual: (simplecov-html 1.12.0)

1. MSG = "<?><?><?><?><?><?><?><?><?><?><?><?>"

Note: <?> seems to be a unicode replacement character.
@Tietew Tietew mentioned this issue Feb 14, 2020
Closed
@Tietew
Copy link
Contributor Author

Tietew commented Feb 14, 2020

#86 can be reverted after above pr is merged because line.src is always UTF-8.

@PragTob
Copy link
Collaborator

PragTob commented Feb 14, 2020

Hi thanks or the error report! 💚

Will take a look!

@PragTob PragTob mentioned this issue Feb 15, 2020
Closed
PragTob added a commit that referenced this issue Feb 22, 2020
@PragTob
Revert "Fix UTF8 encoding error"
81e49c9 
This reverts commit 2608b9d.

Replaced by: simplecov-ruby/simplecov#866
As suggested by: #91 (comment)
Should be safe to revert as apparently ruby itself doesn't work
when the encoding isn't declared properly so should be good.

For files that aren't required by ruby but tracked we added a
test case with broken encoding (in simplecov main) but it still
seems to work.  So this complexity is likely not needed anymore.
@PragTob PragTob mentioned this issue Feb 22, 2020
Merged
PragTob added a commit that referenced this issue Feb 23, 2020
@PragTob
Revert "Fix UTF8 encoding error"
3fada40 
This reverts commit 2608b9d.

Replaced by: simplecov-ruby/simplecov#866
As suggested by: #91 (comment)
Should be safe to revert as apparently ruby itself doesn't work
when the encoding isn't declared properly so should be good.

For files that aren't required by ruby but tracked we added a
test case with broken encoding (in simplecov main) but it still
seems to work.  So this complexity is likely not needed anymore.
@PragTob
Copy link
Collaborator

PragTob commented Feb 23, 2020

Fixed via simplecov-ruby/simplecov#866 and thank you very much!

@PragTob PragTob closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert source file encoding to UTF-8 Tietew/simplecov
2 participants
@Tietew @PragTob