Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16 Uncovered source files. #252

Closed
wants to merge 5 commits into from
Closed

#16 Uncovered source files. #252

wants to merge 5 commits into from

Conversation

jwickard
Copy link

@jwickard jwickard commented Oct 6, 2013

implements Feature from issue #16

Off by default, but if someone wants it, they can just set show_uncovered_files to true in the config block.

Why aren't there tests?

I tried to write a few features to demonstrate the functionality but the way the test harness run it touches the uncovered source file and shows up in the coverage data. So basically when I run the tests I can't recreate the issue.

If it's a big deal maybe I can spend some time in the future trying to work that up.

@colszowka
Copy link
Collaborator

Thanks. Yeah, it would be nice to have a setup that verifies this in a cuke feature so I don't accidentally break this in the future. Not sure whether we'd need a separate faked project, but probably the current one would work just fine by just running the code instead of a specific test suite.

@kstevens715
Copy link

@jwickard, thanks for this, I just tested out your branch on my project and it's very close to what I was trying to do.
What do you think about making the glob configurable instead of always using '*/.rb'? This would do two things. One, it would provide more flexibility. For example, I'd probably just want to include /lib and /app in my Rails project. Two, I was thinking it might make it easier for you to test? (maybe not).

Maybe another way to test it would be to dynamically create the "uncovered" file in the test?

@sferik sferik force-pushed the master branch 2 times, most recently from 689480e to ec43ea9 Compare September 20, 2014 05:57
@bf4
Copy link
Collaborator

bf4 commented Feb 18, 2015

You up for updating this?

@sferik sferik force-pushed the master branch 9 times, most recently from c7c5ad5 to 4c39fa3 Compare April 18, 2015 12:02
@sferik
Copy link
Collaborator

sferik commented Apr 18, 2015

Ping! I’m trying to put together a new release. Please update if you want this feature included.

@sferik sferik force-pushed the master branch 6 times, most recently from fd640fa to 739cf4d Compare April 19, 2015 05:53
@bf4
Copy link
Collaborator

bf4 commented Aug 23, 2015

@jwickard would you be up to rebasing this?

@xaviershay
Copy link
Collaborator

Replaced by #422.

@xaviershay xaviershay closed this Nov 28, 2015
@nathanvda nathanvda mentioned this pull request Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants