New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码优化。if else 改 switch case #137

Closed

kvii wants to merge 2 commits into simplezhli:master from kvii:pullrequest

kvii commented Jul 5, 2020

将 lib/net/error_handle.dart 中的 handleException 由 if else 语句改为 switch case 语句，并未做逻辑上的修改.
注意代码修改后未经测试，仅做目视检查
详见提交分支中的 README.md

kvii and others added 2 commits

July 5, 2020 10:46


          Update README.md

0de8038


          修改 error_handle.dart

20c6f3b

Owner

simplezhli commented Jul 5, 2020

感谢你的RP！不过对于这个判断优化，我想采用枚举拓展加Map替代分支语句，毕竟实际的错误类型不止这些，switch在这种情况下也不是一个好的方案。

kvii closed this

simplezhli added a commit that referenced this pull request


          #137 优化ExceptionHandle

f2ed1bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet