Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish-listing uses default encoding when reading text files #601

Closed
WonderCsabo opened this issue Mar 6, 2015 · 7 comments
Closed

publish-listing uses default encoding when reading text files #601

WonderCsabo opened this issue Mar 6, 2015 · 7 comments
Milestone
4.2.0

Comments

@WonderCsabo
Copy link
Contributor

I have listing text files stored with UTF-8 encoding. However, it seems the mojo uses the platform default encoding (which is not UTF-8 on Windows) when reading those files. This results in badly interpreted characters get uploaded to the play store.

I think we should either use a configurable property for this, or just hardcode the defacto standard UTF-8.

What do you guys think?
kedzie pushed a commit to kedzie/maven-android-plugin that referenced this issue Mar 6, 2015
@malachid
Travis fix for build simpligility#601 change
8a08d2c
kedzie pushed a commit to kedzie/maven-android-plugin that referenced this issue Mar 6, 2015
@mosabua
Merge pull request simpligility#472 from malachid/master
f7775f1 
Travis fix for build simpligility#601 change
@mosabua
Copy link
Member

mosabua commented Mar 6, 2015

The mojo should probably use the soruce encoding configured in the pom. Want to send a pull request?

@WonderCsabo
Copy link
Contributor Author

Already on it. project.build.sourceEncoding ?

@mosabua
Copy link
Member

mosabua commented Mar 6, 2015

I would think so

@mosabua
Copy link
Member

mosabua commented Mar 6, 2015

I would consider the listing a source file .. right?

@mosabua
Copy link
Member

mosabua commented Mar 6, 2015

Just like src/main/resources and others.

@WonderCsabo
Copy link
Contributor Author

Actually i wanted to write that in the OP, i agree with you.

@WonderCsabo WonderCsabo mentioned this issue Mar 6, 2015
Merged
@WonderCsabo
Copy link
Contributor Author

Implemented.

@mosabua mosabua added this to the 4.2.0 milestone Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
2 participants
@mosabua @WonderCsabo