Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Testing Support Library #623

Closed
secondsun opened this issue Apr 23, 2015 · 3 comments · Fixed by #625
Closed

Support the Testing Support Library #623

secondsun opened this issue Apr 23, 2015 · 3 comments · Fixed by #625

Comments

@secondsun
Copy link
Contributor

So we (humanity) now have Google official JUnit4 support for Android! (see Testing Support Library). Unfortunately AndroidTestFinder does not look for classes annotated with the Test Support annotations. Instead it looks for descendants of the old testing classes. It doesn't find any (because they are annotation based) and thus poops out.

I propose (and volunteer to) enhance the AndroidTestFinder class to check for annotations if the instrumentationTestRunner is set to "android.support.test.runner.AndroidJUnitRunner".

Thoughts?

@mosabua
Copy link
Member

mosabua commented Apr 23, 2015

I would love that! Ideally with an example project as well. Wdyt @simpligility/android-maven-plugins-core-committers

@Shusshu
Copy link
Member

Shusshu commented Apr 24, 2015

Yes we have to support it!
On 24 Apr 2015 00:34, "Manfred Moser" [email protected] wrote:

I would love that! Ideally with an example project as well. Wdyt
@simpligility/android-maven-plugins-core-committers
https://github.com/orgs/simpligility/teams/android-maven-plugins-core-committers


Reply to this email directly or view it on GitHub
#623 (comment)
.

secondsun added a commit to secondsun/aerogear-android-pipe that referenced this issue Apr 24, 2015
@secondsun
Copy link
Contributor Author

A very initial hack https://github.com/secondsun/maven-android-plugin/tree/Junit4TestRunner
Will add automated tests later, but here is a sample project using it : https://github.com/secondsun/aerogear-android-pipe/tree/Junit4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants