Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude all except jar dependcies from proguard -injar parameters #191

Merged
merged 1 commit into from
May 22, 2013

Conversation

tprochazka
Copy link
Contributor

This pull request will fix this issue:
https://code.google.com/p/maven-android-plugin/issues/detail?id=319

Before Proguard was called also with .so or any other dependency type except .apklib. Now only .jar is propagated as -injars parameters.

@mosabua
Copy link
Member

mosabua commented Apr 9, 2013

Does this work with the examples projects? Is it backwards compatible because the other types basically did not work before anyway?

@tprochazka
Copy link
Contributor Author

I tested it only on my project and by included unit tests.
By example project you mean this https://github.com/jayway/maven-android-plugin-samples?
I will test it.
But I can imagine reason why it should not work, because -injar parameters is designed only for jar, proguard can't work with any other dependency type or you know about some?

@tprochazka
Copy link
Contributor Author

I just try to test latest snapshot with this my patch included and all tests passed, except:

Android NDK - Java Native Mixed with APKLIB Dependency Sample FAILURE [0.669s]

[ERROR] Failed to execute goal com.jayway.maven.plugins.android.generation2:android-maven-plugin:3.5.4-SNAPSHOT:ndk-build (default) on project mixed-java-native-with-apklib-dependency: Source 'D:_PJa
zyky_Android_libs_maven\maven-android-plugin-samples\native\mixed-java-native-with-apklib-dependency\target\ndk-libs\armeabi\libmixed-java-native-with-apklib-dependency.so' does not exist -> [Help
1]

But this is not related to my changes and it fail also without my change.

@tprochazka
Copy link
Contributor Author

And what block this pull request?

@mosabua
Copy link
Member

mosabua commented May 17, 2013

I just have not had time to test it yet. I am hoping to do that next week and include it in the release..

@mosabua mosabua merged commit f554c91 into simpligility:master May 22, 2013
@tprochazka tprochazka deleted the pull_fix_proguard-injar branch June 26, 2013 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants