Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint from the dependency #528

Merged
merged 3 commits into from
Dec 10, 2014
Merged

Lint from the dependency #528

merged 3 commits into from
Dec 10, 2014

Conversation

Shusshu
Copy link
Member

@Shusshu Shusshu commented Dec 4, 2014

Close #357
Close #400
Close #476

This is not activated by default as it currently does not do everything it is supposed to do but it is a start

Use Lint from the dependency instead of the android sdk

@Shusshu
Copy link
Member Author

Shusshu commented Dec 4, 2014

Can someone look at this and/or test this?

It can be merged already

3-4 things are missing but anyway it's not activated by default.

@mosabua
Copy link
Member

mosabua commented Dec 4, 2014

We need to add an IT test for this back in that replicates to some degree what the old test did.

@Shusshu
Copy link
Member Author

Shusshu commented Dec 4, 2014

Harder to do as the new test thing is more limited no?
On 4 Dec 2014 21:29, "Manfred Moser" [email protected] wrote:

We need to add an IT test for this back in that replicates to some degree
what the old test did.


Reply to this email directly or view it on GitHub
#528 (comment)
.

@Shusshu
Copy link
Member Author

Shusshu commented Dec 5, 2014

Do you mind if I merge this in its current state (working for my use case) lint does not check libraries yet (but that's not a big deal since you don't modify libraries) ?
Plus it's off by default.

I agree we need tests too but I'm gonna spend some time on the manifest merger v2 or at least try

mosabua added a commit that referenced this pull request Dec 10, 2014
@mosabua mosabua merged commit 68d3b56 into master Dec 10, 2014
@mosabua
Copy link
Member

mosabua commented Dec 10, 2014

I killed the branch as well ... just create another one with whatever new changes you plan..

@mosabua mosabua deleted the lint branch December 10, 2014 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint failure with 4.0.0-rc.1 Lint lombok lib is missing Lint
2 participants