Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making unpacked-libs folder configurable. #538

Merged
merged 1 commit into from
Dec 13, 2014
Merged

Making unpacked-libs folder configurable. #538

merged 1 commit into from
Dec 13, 2014

Conversation

william-ferguson-au
Copy link
Contributor

I've noticed lately (perhaps since upgrading to IntelliJ 14.0.2?? though I think it was happening before that) that IntelliJ is placing a file lock on the AAR dependency jar files (ie classes.jar and whatever matches libs/*.jar) that have been exctrated into target/unpacked-libs/

This means that mvn clean fails - which sucks.

I can understand why IntelliJ might do that as it provides auto complete based upon classes in the classpath. So I don't really think it is IntelliJ's fault.

One way of dealing is to allow that unpacked-libs folder to be configurable so that it could be placed outside of /target.

This PR provides an unpackedLibsFolder parameter (default remains /target/unpacked-libs) that specifies where the unpacked libs will be placed.
I also changed the UnpackedLibHelper to append the unpacked-lib's version to the libs folder name.

@Shusshu
Copy link
Member

Shusshu commented Dec 13, 2014

Yup +1 or shall I merge?

@william-ferguson-au
Copy link
Contributor Author

If you're happy then merge.
This change has made my life easier again :-)

ᐧ

On Sat, Dec 13, 2014 at 3:54 PM, Benoit Billington <[email protected]

wrote:

Yup +1 or shall I merge?

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

Shusshu added a commit that referenced this pull request Dec 13, 2014
@Shusshu
Merge pull request #538 from simpligility/configurable_unpacked-libs
d449b83 
Making unpacked-libs folder configurable.
@Shusshu Shusshu merged commit d449b83 into master Dec 13, 2014
@Shusshu Shusshu deleted the configurable_unpacked-libs branch December 13, 2014 06:28
@malachid
Copy link
Contributor

Was it failing silently? I always do 'clean install' and never noticed a
problem. Maybe OS-specific?

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Fri, Dec 12, 2014 at 6:51 PM, William Ferguson [email protected]
wrote:

I've noticed lately (perhaps since upgrading to IntelliJ 14.0.2?? though I
think it was happening before that) that IntelliJ is placing a file lock on
the AAR dependency jar files (ie classes.jar and whatever matches
libs/*.jar) that have been exctrated into target/unpacked-libs/

This means that mvn clean fails - which sucks.

I can understand why IntelliJ might do that as it provides auto complete
based upon classes in the classpath. So I don't really think it is
IntelliJ's fault.

One way of dealing is to allow that unpacked-libs folder to be
configurable so that it could be placed outside of /target.

This PR provides an unpackedLibsFolder parameter (default remains
/target/unpacked-libs) that specifies where the unpacked libs will be
placed.
I also changed the UnpackedLibHelper to append the unpacked-lib's version

to the libs folder name.

You can merge this Pull Request by running

git pull https://github.com/simpligility/android-maven-plugin configurable_unpacked-libs

Or view, comment on, or merge it at:

#538
Commit Summary

  • Making unpacked-libs folder configurable.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#538.

@william-ferguson-au
Copy link
Contributor Author

Not silently. Clean would fail.
Probably OS specific. I'm running Windows8.1

[image: photo]
William Ferguson
Founder and CEO, XandarMob
m:+61 425 716 870 | e:[email protected] |
w:https://wylas-timing.com
http://lexathon.com <http://wylas-timing.com http://lexathon.com>
ᐧ

On Sat, Dec 13, 2014 at 5:07 PM, Malachi de AElfweald <
[email protected]> wrote:

Was it failing silently? I always do 'clean install' and never noticed a
problem. Maybe OS-specific?

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Fri, Dec 12, 2014 at 6:51 PM, William Ferguson <
[email protected]>
wrote:

I've noticed lately (perhaps since upgrading to IntelliJ 14.0.2?? though
I
think it was happening before that) that IntelliJ is placing a file lock
on
the AAR dependency jar files (ie classes.jar and whatever matches
libs/*.jar) that have been exctrated into target/unpacked-libs/

This means that mvn clean fails - which sucks.

I can understand why IntelliJ might do that as it provides auto complete
based upon classes in the classpath. So I don't really think it is
IntelliJ's fault.

One way of dealing is to allow that unpacked-libs folder to be
configurable so that it could be placed outside of /target.

This PR provides an unpackedLibsFolder parameter (default remains
/target/unpacked-libs) that specifies where the unpacked libs will be
placed.
I also changed the UnpackedLibHelper to append the unpacked-lib's
version

to the libs folder name.

You can merge this Pull Request by running

git pull https://github.com/simpligility/android-maven-plugin
configurable_unpacked-libs

Or view, comment on, or merge it at:

#538
Commit Summary

  • Making unpacked-libs folder configurable.

File Changes

(9)

  • M

src/main/java/com/jayway/maven/plugins/android/common/UnpackedLibHelper.java

<
https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-1>

(21)

  • M

src/main/java/com/jayway/maven/plugins/android/phase_prebuild/ClasspathModifierLifecycleParticipant.java

<
https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-2>

(13)

Patch Links:

—
Reply to this email directly or view it on GitHub
#538.

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

@malachid
Copy link
Contributor

Ok. I was running on Ubuntu.

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Sat, Dec 13, 2014 at 4:33 PM, William Ferguson [email protected]
wrote:

Not silently. Clean would fail.
Probably OS specific. I'm running Windows8.1

[image: photo]
William Ferguson
Founder and CEO, XandarMob
m:+61 425 716 870 | e:[email protected] |
w:https://wylas-timing.com
http://lexathon.com <http://wylas-timing.com http://lexathon.com>
ᐧ

On Sat, Dec 13, 2014 at 5:07 PM, Malachi de AElfweald <
[email protected]> wrote:

Was it failing silently? I always do 'clean install' and never noticed a
problem. Maybe OS-specific?

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Fri, Dec 12, 2014 at 6:51 PM, William Ferguson <
[email protected]>
wrote:

I've noticed lately (perhaps since upgrading to IntelliJ 14.0.2??
though
I
think it was happening before that) that IntelliJ is placing a file
lock
on
the AAR dependency jar files (ie classes.jar and whatever matches
libs/*.jar) that have been exctrated into target/unpacked-libs/

This means that mvn clean fails - which sucks.

I can understand why IntelliJ might do that as it provides auto
complete
based upon classes in the classpath. So I don't really think it is
IntelliJ's fault.

One way of dealing is to allow that unpacked-libs folder to be
configurable so that it could be placed outside of /target.

This PR provides an unpackedLibsFolder parameter (default remains
/target/unpacked-libs) that specifies where the unpacked libs will be
placed.
I also changed the UnpackedLibHelper to append the unpacked-lib's
version

to the libs folder name.

You can merge this Pull Request by running

git pull https://github.com/simpligility/android-maven-plugin
configurable_unpacked-libs

Or view, comment on, or merge it at:

#538
Commit Summary

  • Making unpacked-libs folder configurable.

File Changes

  • M

src/main/java/com/jayway/maven/plugins/android/AbstractAndroidMojo.java
<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-0>

(9)

  • M

src/main/java/com/jayway/maven/plugins/android/common/UnpackedLibHelper.java

<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-1>

(21)

  • M

src/main/java/com/jayway/maven/plugins/android/phase_prebuild/ClasspathModifierLifecycleParticipant.java

<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-2>

(13)

Patch Links:

—
Reply to this email directly or view it on GitHub
#538.

—
Reply to this email directly or view it on GitHub
<
https://github.com/simpligility/android-maven-plugin/pull/538#issuecomment-66867887>

.

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

@Shusshu
Copy link
Member

Shusshu commented Dec 14, 2014

I also had issue under Windows 7 and 8
On 14 Dec 2014 06:04, "Malachi de AElfweald" [email protected]
wrote:

Ok. I was running on Ubuntu.

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Sat, Dec 13, 2014 at 4:33 PM, William Ferguson <
[email protected]>
wrote:

Not silently. Clean would fail.
Probably OS specific. I'm running Windows8.1

[image: photo]
William Ferguson
Founder and CEO, XandarMob
m:+61 425 716 870 | e:[email protected] |
w:https://wylas-timing.com
http://lexathon.com <http://wylas-timing.com http://lexathon.com>
ᐧ

On Sat, Dec 13, 2014 at 5:07 PM, Malachi de AElfweald <
[email protected]> wrote:

Was it failing silently? I always do 'clean install' and never noticed
a
problem. Maybe OS-specific?

Malachi de Ælfweald
http://www.google.com/profiles/malachid

On Fri, Dec 12, 2014 at 6:51 PM, William Ferguson <
[email protected]>
wrote:

I've noticed lately (perhaps since upgrading to IntelliJ 14.0.2??
though
I
think it was happening before that) that IntelliJ is placing a file
lock
on
the AAR dependency jar files (ie classes.jar and whatever matches
libs/*.jar) that have been exctrated into target/unpacked-libs/

This means that mvn clean fails - which sucks.

I can understand why IntelliJ might do that as it provides auto
complete
based upon classes in the classpath. So I don't really think it is
IntelliJ's fault.

One way of dealing is to allow that unpacked-libs folder to be
configurable so that it could be placed outside of /target.

This PR provides an unpackedLibsFolder parameter (default remains
/target/unpacked-libs) that specifies where the unpacked libs will
be
placed.
I also changed the UnpackedLibHelper to append the unpacked-lib's
version

to the libs folder name.

You can merge this Pull Request by running

git pull https://github.com/simpligility/android-maven-plugin
configurable_unpacked-libs

Or view, comment on, or merge it at:

#538
Commit Summary

  • Making unpacked-libs folder configurable.

File Changes

  • M

src/main/java/com/jayway/maven/plugins/android/AbstractAndroidMojo.java
<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-0>

(9)

  • M

src/main/java/com/jayway/maven/plugins/android/common/UnpackedLibHelper.java

<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-1>

(21)

  • M

src/main/java/com/jayway/maven/plugins/android/phase_prebuild/ClasspathModifierLifecycleParticipant.java

<

https://github.com/simpligility/android-maven-plugin/pull/538/files#diff-2>

(13)

Patch Links:

https://github.com/simpligility/android-maven-plugin/pull/538.patch

—
Reply to this email directly or view it on GitHub
#538.

—
Reply to this email directly or view it on GitHub
<

https://github.com/simpligility/android-maven-plugin/pull/538#issuecomment-66867887>

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/simpligility/android-maven-plugin/pull/538#issuecomment-66897582>

.

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

@mosabua
Copy link
Member

mosabua commented Dec 16, 2014

Changelog update should be added ideally..

@william-ferguson-au
Copy link
Contributor Author

Is that under SCM?
Where will I find it?
ᐧ

On Tue, Dec 16, 2014 at 1:53 PM, Manfred Moser [email protected]
wrote:

Changelog update should be added ideally..

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

@mosabua
Copy link
Member

mosabua commented Dec 16, 2014

https://github.com/simpligility/android-maven-plugin/blob/master/src/site/asciidoc/changelog.adoc

@william-ferguson-au
Copy link
Contributor Author

Done
ᐧ

On Tue, Dec 16, 2014 at 2:52 PM, Manfred Moser [email protected]
wrote:

https://github.com/simpligility/android-maven-plugin/blob/master/src/site/asciidoc/changelog.adoc

—
Reply to this email directly or view it on GitHub
#538 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@william-ferguson-au @Shusshu @malachid @mosabua