Fixing #529 #565
Merged
Fixing #529 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of appending a string to the created dependency
secondsun
force-pushed
the
release_plugin_fix
branch
from
c676315 to
d9091a5
Compare
|
So the build is failing because Travis doesn't have API level 21 for the tic tac toe example. Everything else looks good though. |
| // Add the classes to the classpath | ||
| final Dependency dependency = createSystemScopeDependency( artifact, classesJar, "extracted" ); | ||
|
|
||
| // Modify the classpath to use an extracted dex file. This will overwrite |
There was a problem hiding this comment.
It's not using an extracted dex file though is it?
It's using the classes.jar from an unpacked aar lib.
There was a problem hiding this comment.
Yes. I'm used to the classes.dex in an apk. I'll fix the doc.
|
Works for our use cases. I'll close the other pull request if this is merged. Thanks |
william-ferguson-au
added a commit
that referenced
this pull request
Jan 17, 2015
Fixing #529 Thanks @secondsun This fixes a really annoying I have been having with IntelliJ which was being caused by the _extracted suffix.
|
NB this PR is required in order for the release-plugin to work also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues #530 is trying to fix but without breaking the provided jar workaround for IDEs