Default includeLibsJarsFromAar to true

[Shusshu]

#583 (comment)

Close #585

[Shusshu]

@william-ferguson-au double check ;)

[mosabua]

We need to make sure the build passes with it and should add a big fat warning in the log somehow.. personally I think we should leave it as false...

[william-ferguson-au]

Intellectually I agree with you Manfred.

But anyone that has to use support-v4 (which will be anyone attempting to
support prior versions of Android - ie everyone) or any of the others SDK
AARs that contain an internal lib will get failures that aren't going to be
immediately clear to them. It's going to appear like AMP is broken.

I think we have to default to include AAR libs.

But perhaps we add a warning IN CAPS everytime we find an AAR containing
internal libs that briefly explains the problem.
ᐧ

On Wed, Feb 18, 2015 at 10:25 AM, Manfred Moser [email protected]
wrote:

We need to make sure the build passes with it and should add a big fat
warning in the log somehow.. personally I think we should leave it as
false...

—
Reply to this email directly or view it on GitHub
#586 (comment)
.

[Shusshu]

We already have warnings to show we are adding internal jars and where they come from...

[william-ferguson-au]

In that case just make it the default.

[image: photo]
William Ferguson
Founder and CEO, XandarMob
m:+61 425 716 870 | e:[email protected] |
w:https://wylas-timing.com
http://lexathon.com <http://wylas-timing.com http://lexathon.com>
ᐧ

On Wed, Feb 18, 2015 at 8:24 PM, Benoit Billington <[email protected]

wrote:

We already have warnings to show we are added internal jars and where they
come from...

—
Reply to this email directly or view it on GitHub
#586 (comment)
.

[mosabua]

Fine by me... although really I would like to club the SDK team over the head and set it to false..

[mosabua]

Can you update the changelog and also change it to 4.2.0 there as next version. This is a compatiblity change worth upgrading minor version for on its own imho

[Shusshu]

Done