Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex support for VersionGenerator #606

Merged
merged 8 commits into from
Apr 14, 2015

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented Mar 10, 2015

This fixes #605, complete with test cases. Hopefully I didn't miss anything important (the XML part is automatically done by the mojo, right?); please review.

Thanks!

@william-ferguson-au
Copy link
Contributor

Haven't had a chance to run it up but it looks good.
Double points for adding tests :-)

@william-ferguson-au
Copy link
Contributor

Any other @simpligility/android-maven-plugins-core-committers want to chime in?

@Shusshu
Copy link
Member

Shusshu commented Mar 11, 2015

I also looked at it and I like it but currently I can't test this.

As I can see in the code the default behaviour will be triggered if you don't specify a pattern so it is a low risk to merge.

Btw thx for the tests +1

@xen0n
Copy link
Contributor Author

xen0n commented Mar 17, 2015

Any heads-up on this? Still I haven't found a way to completely implement the old behaviour with regexes. I'd rather not introduce flags or similar things, only for the sake of getting rid of old code...

@mosabua
Copy link
Member

mosabua commented Mar 31, 2015

So wdyt @simpligility/android-maven-plugins-core-committers .. pull this in and break old behaviour as part of a 4.2.0 release?

@william-ferguson-au
Copy link
Contributor

Yep - merge it.

@Shusshu
Copy link
Member

Shusshu commented Apr 5, 2015

Merge this in :)
Btw it does not break old behaviour as it can still fallback to the old code...

mosabua added a commit that referenced this pull request Apr 14, 2015
Regex support for VersionGenerator
@mosabua mosabua merged commit c27e49a into simpligility:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More flexibility in versionCode generator
4 participants