-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex support for VersionGenerator #606
Conversation
Haven't had a chance to run it up but it looks good. |
Any other @simpligility/android-maven-plugins-core-committers want to chime in? |
I also looked at it and I like it but currently I can't test this. As I can see in the code the default behaviour will be triggered if you don't specify a pattern so it is a low risk to merge. Btw thx for the tests +1 |
Any heads-up on this? Still I haven't found a way to completely implement the old behaviour with regexes. I'd rather not introduce flags or similar things, only for the sake of getting rid of old code... |
So wdyt @simpligility/android-maven-plugins-core-committers .. pull this in and break old behaviour as part of a 4.2.0 release? |
Yep - merge it. |
Merge this in :) |
Regex support for VersionGenerator
This fixes #605, complete with test cases. Hopefully I didn't miss anything important (the XML part is automatically done by the mojo, right?); please review.
Thanks!