Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra arguments at (or near) the end of aapt command #649

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Add extra arguments at (or near) the end of aapt command #649

merged 1 commit into from
Jul 2, 2015

Conversation

toonetown
Copy link
Contributor

If you want to add additional raw file directories to the apk, you can specify them in extra arguments - however, these should come last in the aapt command (with the exception of --output-text-symbols - which is used when generating the R.txt file. This PR just moves the addExtraArguments call later in the command list.

If you want to add additional raw file directories to the apk, you can specify them in extra arguments - however, these should come last in the aapt command (with the exception of --output-text-symbols - which is used when generating the R.txt file.  This PR just moves the addExtraArguments later in the command list.
@Shusshu
Copy link
Member

Shusshu commented Jul 2, 2015

If you add raw file directories currently does it fails?

Otherwise the code looks right. Haven't tested so if someone would like to +1 & merge that would be perfect.

@toonetown
Copy link
Contributor Author

@Shusshu yes - if you add raw file directories and enable debug, it would fail...since the --debug-mode flag would appear after the files, and the build system tries to add a directory called "--debug".

Shusshu added a commit that referenced this pull request Jul 2, 2015
Add extra arguments at (or near) the end of aapt command
@Shusshu Shusshu merged commit 5cecd7a into simpligility:master Jul 2, 2015
@Shusshu
Copy link
Member

Shusshu commented Jul 2, 2015

You might want to add this to the changelog

@toonetown
Copy link
Contributor Author

@Shusshu I can do that (add to changelog) - just the src/site/asciidoc/changelog.adoc file? Or are there different places to keep track of it?

Also - separate pull request, or should I append this one?

@Shusshu
Copy link
Member

Shusshu commented Jul 2, 2015

Separate is fine, or can you really add to this one since I merge already?

@toonetown
Copy link
Contributor Author

Not sure - I'll just submit a new one. Thanks!

@toonetown toonetown deleted the aapt-extra-args branch July 2, 2015 20:03
@toonetown
Copy link
Contributor Author

Second PR submitted: #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants