Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Proguard dependency from Central by default #725

Merged

Conversation

WonderCsabo
Copy link
Contributor

Implements #724 .

@@ -113,8 +112,8 @@
private String[] parsedOptions;

/**
* Path to the proguard jar and therefore version of proguard to be used. By default this will load the jar from
* the Android SDK install. Overriding it with an absolute path allows you to use a newer or custom proguard
* Path to the proguard jar and therefore version of proguard to be used. By default this will use Proguard 5.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't specify the version in the comment, or the comment will have to be updated every time the dependency is. "use Proguard from the Central Repository" should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated.

On 16 May 2016 at 21:33, Malachi de AElfweald [email protected]
wrote:

In
src/main/java/com/simpligility/maven/plugins/android/phase04processclasses/ProguardMojo.java
#725 (comment)
:

@@ -113,8 +112,8 @@
private String[] parsedOptions;

 /**
  • \* Path to the proguard jar and therefore version of proguard to be used. By default this will load the jar from
    
  • \* the Android SDK install. Overriding it with an absolute path allows you to use a newer or custom proguard
    
  • \* Path to the proguard jar and therefore version of proguard to be used. By default this will use Proguard 5.2.1
    

Shouldn't specify the version in the comment, or the comment will have to
be updated every time the dependency is. "use Proguard from the Central
Repository" should be fine.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/simpligility/android-maven-plugin/pull/725/files/339e379c2d36df68e20846508b3c8dcac82e0817#r63410938

@william-ferguson-au william-ferguson-au merged commit 648d22f into simpligility:master May 16, 2016
@WonderCsabo WonderCsabo deleted the 724_newProguard branch May 17, 2016 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants