Update Default SDK Version to API 23 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, 24 is already available for using in published apps. |
|
Yeah, this could be bumped up to api 24. Wasn't sure whether that should happen yet since it's not technically available for any devices yet. Maybe this pr could just be closed out, and redone in a couple weeks/months when Android N has a full release? or it could be updated here now, but it seems a bit early at the moment. |
|
Can you add a changelog update? Then I can merge. |
caseykulm
force-pushed
the
update_default_sdk_version_23
branch
from
5b5311d to
c393ec4
Compare
|
Rebased to one commit. |
caseykulm
force-pushed
the
update_default_sdk_version_23
branch
from
c393ec4 to
d8b8bcf
Compare
|
Rebased again on latest master, as well as fixing my changelog format to match the other changelog entries. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a while this will be able to be changed to API 24, but for now it could definitely stand to be updated to API 23. I'm also not sure if there is any good place (or if it would be desirable) to log in the build process that the android-maven-plugin has decided to choose a default api level, and maybe a reference to the pom option to configure it.