-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cors origin port issue #59
Conversation
…y_raw/2 and body_qs/2
It returns allowed headers for preflight requests and sets the header `access-control-allow-headers`.
…ication/msgpack", "application/x-www-form-urlencoded"
This reverts commit 9d9d0be.
…in content_type/1
Does this fix it? What does cross_domains callback value need to be? I'm currently using:
No port works:
Port does not work:
|
Sorry my bad. I didn't I brought this into my own fork which upgrades the jiffy version. |
…-master Conflicts: src/leptus_req.erl
|
||
{deps, [ | ||
{cowboy, ".*", {git, "git://github.com/extend/cowboy.git", {tag, "0.9.0"}}}, | ||
{jiffy, ".*", {git, "git://github.com/davisp/jiffy.git", {tag, "0.8.5"}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naive question.. what is the effect of removing jiffy here? I am using a combination of leptus and Jiffy in a few projects; is Jiffy completely interchangeable with msgpack, such that jiffy + leptus 1.0.0 (your proposal here) is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I didn't meant this PR be such big. It is actually my mistake as I initially made a PR from my master branch. Now I added a lot of stuff to my master and it all appeared here. I'm going to close this PR.
As regards to your question, jiffy has been removed as an alternative to jsx (https://github.com/talentdeficit/jsx.git). leptus originally supported two different JSON libraries, in my changes it supports only one (jsx). msgpack is still supported as before.
Repeating this:
https://git.teknorota.com/yekmyk/leptus/commit/b417c7b0693125522a5f9e238ad99550d4adf293
Fixes #55