Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add material spinner #44

Merged
merged 4 commits into from
Jul 12, 2020
Merged

Add material spinner #44

merged 4 commits into from
Jul 12, 2020

Conversation

Richienb
Copy link
Contributor

@sindresorhus
Copy link
Owner

Close, but any chance you can make it more fluid?

Look at the spinner in https://material.io/components/progress-indicators#linear-progress-indicators. It changes size.

@sindresorhus sindresorhus changed the title Add Material Spinner Add material spinner Apr 21, 2020
@Richienb
Copy link
Contributor Author

Richienb commented Apr 21, 2020

@sindresorhus How many characters long should the spinner be? The more, the easier to increase fluidity but too many would make it take up too much space.

@sindresorhus
Copy link
Owner

Not more than 20.

@Richienb
Copy link
Contributor Author

@sindresorhus I've just eyeballed the entire animation at 60fps. It should be fluid enough now.

@sindresorhus
Copy link
Owner

Almost. The material loader seems to stretch on the first line, and on the second round it shrinks. I only see the latter here.

@Richienb
Copy link
Contributor Author

Richienb commented Apr 21, 2020

@sindresorhus You've just described the correct result - try rewatching the animation from the spec.

@sindresorhus
Copy link
Owner

I saw it. I just think the stretching could be done in a couple of fewer frames so it's more visible.

@Richienb
Copy link
Contributor Author

@sindresorhus The stretching time is exactly the same as the original - I wouldn't know how to make it faster without breaking the spec.

Spinner Comparison

@sindresorhus
Copy link
Owner

I have been watching both my terminal and your GIF and it's pretty clear to me that it doesn't stretch as much as in the original material spinner.

I would start the spinner a tiny bit smaller, so the stretch is more clear.

@sindresorhus
Copy link
Owner

Bump

Richienb added 2 commits July 10, 2020 02:01
Signed-off-by: Richie Bendall <[email protected]>
Signed-off-by: Richie Bendall <[email protected]>
@Richienb
Copy link
Contributor Author

Richienb commented Jul 9, 2020

@sindresorhus

I just think the stretching could be done in a couple of fewer frames so it's more visible.

Done.

@sindresorhus sindresorhus merged commit 1e7d53c into sindresorhus:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants