-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add material
spinner
#44
Conversation
Close, but any chance you can make it more fluid? Look at the spinner in https://material.io/components/progress-indicators#linear-progress-indicators. It changes size. |
@sindresorhus How many characters long should the spinner be? The more, the easier to increase fluidity but too many would make it take up too much space. |
Not more than 20. |
@sindresorhus I've just eyeballed the entire animation at 60fps. It should be fluid enough now. |
Almost. The material loader seems to stretch on the first line, and on the second round it shrinks. I only see the latter here. |
@sindresorhus You've just described the correct result - try rewatching the animation from the spec. |
I saw it. I just think the stretching could be done in a couple of fewer frames so it's more visible. |
@sindresorhus The stretching time is exactly the same as the original - I wouldn't know how to make it faster without breaking the spec. |
I have been watching both my terminal and your GIF and it's pretty clear to me that it doesn't stretch as much as in the original material spinner. I would start the spinner a tiny bit smaller, so the stretch is more clear. |
Bump |
Signed-off-by: Richie Bendall <[email protected]>
Signed-off-by: Richie Bendall <[email protected]>
Done. |
cc @sindresorhus