-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter
option
#66
Conversation
Windows tests not passing, but not affected by this patch. |
I need your feedback on #48 (comment). I think we could use the idea here too. |
@sindresorhus Well, I reworked it to work like #48 (comment) . |
1955af9 is not really what I proposed in #48 (comment). |
@sindresorhus What part do you mean? I read it again and the only differences I found are:
Though I didn't understand what can It might be that either you failed to describe the design you see or I completely failed at understanding it. |
Yes. I like to be defensive. It's too easy to make mistakes in JS.
I'm fine with that, except
Sure, but the intention is to unify them so they both use the exact same kind of "file" object.
That's only really useful for
Probably me not being clear enough. If I'm ever not clear enough, please let me know. |
I've seen |
re: Proxy |
You’re right. Getters/setters is a better choice in this case. |
@sindresorhus Are you sure about resolved path vs non-resolved path? As cpy operates in "scope" of cwd, users probably won't care about full resolved path for filtering purposes. In any case, including |
I agree the resolved path is not that useful in a filtering purpose. However, it's good to have it for consistency with the file object that will be used in the rename option. And also, there are scenarios where you'd want the full path. For example, when you filter based on files outside the |
Ping :) |
|
@stroncium Bump :) |
Co-Authored-By: Sindre Sorhus <[email protected]>
@sindresorhus added |
filter
optionFixes #63
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
filter
optionIssueHunt has been backed by the following sponsors. Become a sponsor