fix tests #10
Merged
fix tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamVerschueren - I think avajs/ava#395 would solve this better. Thoughts? |
|
That's how I did it before avajs/ava#360. So not sure why it was removed... Although not sure if it was removed in |
|
It was removed in |
Which is nice :)
You can't always oversee all the use cases :). |
|
@SamVerschueren Why not just remove the |
|
Because it needs to know the time it takes to reject the promise, I have to wait for the promise to reject. |
|
Ah, missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to rewrite some tests because of avajs/ava#360. Not sure if it can be written cleaner or better?