Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'latest' as ecmaVersion #1465

Merged
merged 17 commits into from
Oct 11, 2021
Merged

Use 'latest' as ecmaVersion #1465

merged 17 commits into from
Oct 11, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Aug 5, 2021

No description provided.

@fisker
Copy link
Collaborator Author

fisker commented Aug 30, 2021

Blocked by typescript-eslint/typescript-eslint#3710 and babel/babel#13638

@sindresorhus
Copy link
Owner

Should we also update these:

rules/import-style.js
139:		ecmaVersion: 2018,

test/consistent-function-scoping.mjs
20:			ecmaVersion: 2021,

?

@fisker fisker mentioned this pull request Sep 8, 2021
Merged
@sindresorhus
Copy link
Owner

TypeScript ESLint PR: typescript-eslint/typescript-eslint#3873

@sindresorhus
Copy link
Owner

This can now be finished: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.32.0

@fisker
Copy link
Collaborator Author

fisker commented Sep 27, 2021

Great, I checked it yesterday, it was not released.

@fisker
Copy link
Collaborator Author

fisker commented Sep 28, 2021

Should we also update these:

rules/import-style.js
139:		ecmaVersion: 2018,

test/consistent-function-scoping.mjs
20:			ecmaVersion: 2021,

?

The second one is replaced.

The first one is passed to eslint-template-visitor, I don't think the old version can understand it yet. Let's update it after eslint-template-visitor update it's dependency.

@fisker fisker marked this pull request as ready for review September 28, 2021 01:10
@sindresorhus
Copy link
Owner

Seems like integration tests are failing.

@sindresorhus
Copy link
Owner

I suggest we just disable the two failing projects for now to make this PR mergeable: https://github.com/sindresorhus/eslint-plugin-unicorn/runs/3855394524#step:5:364

@sindresorhus sindresorhus merged commit 9feb181 into sindresorhus:main Oct 11, 2021
@fisker fisker deleted the ecma-version-latest branch October 12, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @sindresorhus