Separate Node.js dependency

[Borewit]

Node.js functions are the default:

const fileType = require('file-type');

(async () => {
    const fileType = await fileType.fromFile('/home/borewit/Pictures/background.png');
    // fileType = {ext: 'png', mime: 'image/png'}
})();

Common (internal) functions are accessible via sub-inclusion (file-type/core):

(async () => {
    const fileType = await fileType.fromTokenizer(tokenizer);
    // fileType = {ext: 'png', mime: 'image/png'}
})();

This is part of the implementation of #248 Change proposal: break the fixed sample limit

[sindresorhus]

I think it should be the other way around. require('file-type') should include the Node.js stuff, and require('file-type/browser'); should be browser-only.

[Borewit]

I think it should be the other way around. require('file-type') should include the Node.js stuff, and require('file-type/browser'); should be browser-only.

Makes sense, I will adjust to your preference (same way as I had done it in my modules, requires a bit more shift code around, that is is why I have not done it).

Okay, I will:

• 'filetype' for Node.js, importing filetype/core
  • fromFile(), reading from file path
  • +core functions
• 'filetype/core' common part, Node.js & browser compatible.
  • fromTokenizer(), reading from tokenizer
  • fromStream(), reading from Node.js readable stream
• 'filetype/browser', descoped for now, importing filetype/core, adding browser specific functions
  • fromStream(), reading from Web-API readable stream
  • fromBlob(), reading from Web-API blob
  • +fromTokenizer() from core

[Borewit]

To convert the Web-API readable stream (from browser part) into Node.js readable stream (core) I planned to use readable-web-to-node-stream.

Would you like to keep /browser as part of file-type or put this in a dedicated module @sindresorhus?

[sindresorhus]

Would you like to keep /browser as part of file-type or put this in a dedicated module @sindresorhus?

I would prefer to keep everything in this package.

[Borewit]

I will prepare a PR adding the browser functions within 2 days.

If you have time, it would be great if you can review & merge, these PR's to the development branch:

• Initial integration with strtok3 #261
• Use tokenizer #262
• Separate Node.js dependency #265

[sindresorhus]

Note: eff47af

[sindresorhus]

Merging this to unblock you, but don't forget to fix #265 (comment)