Add unit tests with non-MP3 files with prefixing ID3v2 headers #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests demonstrating issue #267 is resolved, with #286.
Note that these fixtures are not detectable withing a 4k boundary.
Therefor methods
fromBuffer()
andstream()
are excluded from the unit tests.Maybe
stream()
could be updated to overcome the 4k limit, but it is tricky, and doubt if it should be part of this module. Anyway, that not where this issue is about, I will come back to that in another issue.Closes #267