Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests with non-MP3 files with prefixing ID3v2 headers #289

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Add unit tests with non-MP3 files with prefixing ID3v2 headers #289

merged 1 commit into from
Jan 6, 2020

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Jan 4, 2020

Add unit tests demonstrating issue #267 is resolved, with #286.

Note that these fixtures are not detectable withing a 4k boundary.
Therefor methods fromBuffer() and stream() are excluded from the unit tests.

Maybe stream() could be updated to overcome the 4k limit, but it is tricky, and doubt if it should be part of this module. Anyway, that not where this issue is about, I will come back to that in another issue.

Closes #267

Add unit test showing issue #267 is implemented.
@sindresorhus sindresorhus changed the title Add unit tests with non-MP3 files with prefixing ID3v2 headers. Add unit tests with non-MP3 files with prefixing ID3v2 headers Jan 6, 2020
@sindresorhus sindresorhus merged commit 5c7d198 into sindresorhus:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect audio files with an ID3 header, which are not MP3
2 participants