Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript type for the .buffer() method #44

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Fix TypeScript type for the .buffer() method #44

merged 2 commits into from
Apr 15, 2021

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 14, 2021

From

get-stream/index.js

Line 59 in 831366e

module.exports.buffer = (stream, options) => getStream(stream, {...options, encoding: 'buffer'});
encoding is always set to buffer

@sindresorhus sindresorhus changed the title buffer does not take encoding option Fix TypeScript type for the .buffer() method Apr 15, 2021
@sindresorhus sindresorhus merged commit 0ee784a into sindresorhus:main Apr 15, 2021
@SimenB SimenB deleted the patch-1 branch April 15, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimenB @sindresorhus