Remove encoding option
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 8, 2023
| const chunkTypes = { | ||
| buffer: {convertChunk: convertChunkToBuffer, getContents: getContentsAsBuffer}, | ||
| string: {convertChunk: convertChunkToString, getContents: getContentsAsString}, | ||
| }; |
There was a problem hiding this comment.
This allows adding more types, such as ArrayBuffer, which would be helpful to support ReadableStream.
This was referenced Aug 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
This removes the
encodingoption.This is a breaking change for users who used the
encodingoption withgetStream()(not withgetStreamAsBuffer()) except if they usedencoding: undefined,encoding: nullorencoding: 'utf8. For users who usedencoding: 'hex', please convert to hexadecimal usingBuffer.from(string).toString('hex'). For those who usedencoding: 'base64', please convert to base64 using eitherBuffer.from(string).toString('base64')or (for better performance on big streams) withb64.