Add .url property for URL of active browser tab on macOS
#63
Conversation
|
Can you update index.d.ts too? |
|
You need to update https://github.com/sindresorhus/active-win/blob/master/index.d.ts too. |
Co-Authored-By: Sindre Sorhus <[email protected]>
Co-Authored-By: Sindre Sorhus <[email protected]>
Co-Authored-By: Sindre Sorhus <[email protected]>
…en issue AppleScript command
Co-Authored-By: Sindre Sorhus <[email protected]>
|
Thanks for the detailed review. I'm very (read: completely) new to Swift so it is helpful to have your feedback here. It's awesome to have someone who responds so quickly to OSS stuff as well! As you'll see, I refactored a bit in alignment with what you were looking for. Let me know if there is more to add with the given changes. Also, did you want me to update the version number and/or the description for |
sindresorhus
changed the title
.url property for URL of active browser tab on macOS
Co-Authored-By: Sindre Sorhus <[email protected]>
|
Great :) |
|
Not sure this will ever be seen by anyone other than you @sindresorhus, but I wanted to say how seamless of an experience it was working with you on this PR. Extremely quick responses, thorough code review and suggestions, and a timely PR...exactly what everyone hopes for when working on OSS. Thanks for your work and keep crushing it! |
|
It was a pleasure working with you too 👍 |
Using AppleScript, this PR updates the
main.swiftfile to include the ability to get the browser URL for the active window if the browser is Safari, Google Chrome, or Brave. Firefox has a much more difficult implementation in AppleScript requiring additional permissions and could be added at a later date if desired.Fixes #62, fixes #54, fixes #45, and fixes #20.