-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade glob to 7.1.2 #45
Conversation
Required by zinserjan/mocha-webpack#145
Not needed since |
The thing is that the minimum version where it works is 7.1.x. @zinserjan can you please comment on this? |
Yep, and that's the problem as we rely on the In my opinion there are 3 ways to fix this:
I would prefer the 2nd option as it's the easiest, does not break other libraries (peerDependency may would) and it's safe to bump as there are no breaking changes in 7.1. |
@sindresorhus what's your opinion on this? |
@kevva could you please re-consider this PR? |
Alright, but we're not doing a new release until #46 is merged, so you might want to add a dependency on |
Got it. Fingers crossed it would happen soon.
|
Required by zinserjan/mocha-webpack#145