New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash placed in wrong location on file name when multiple periods in name #244

Closed

phazei opened this issue Jun 5, 2018 · 3 comments

Labels

bug help wanted

Contributor

phazei commented Jun 5, 2018

I have files named:
site.subsite.js

when I use rev, instead of:
site.subsite-xxx.js
I get:
site-xxx.subsite.js

Is this a bug? Is there a work around?

phazei changed the title ~~hash placed in wrong location on file~~ hash placed in wrong location on file name

phazei changed the title ~~hash placed in wrong location on file name~~ hash placed in wrong location on file name when multiple periods in name

Contributor Author

phazei commented Jun 5, 2018 •

edited

Loading

hmm, I think this can be worked around with #169

For this particular case though, I do feel like it should do that by default. I presume the original intention was to put the hash directly before the extension. So based on that, this could be considered a bug.

Owner

sindresorhus commented Jun 5, 2018

Yeah, I think putting the hash before the last extension would be the best default behavior.

sindresorhus added bug help wanted labels

sindresorhus changed the title ~~hash placed in wrong location on file name when multiple periods in name~~ Hash placed in wrong location on file name when multiple periods in name

Contributor Author

phazei commented Jun 5, 2018

It did it right in v4. I'd just upgraded to v8 today.

phazei added a commit to phazei/gulp-rev that referenced this issue


          Put hash right before file extension

63e4992

This fixes sindresorhus#244

phazei mentioned this issue

Put hash right before the last file extension #245

Merged

sindresorhus closed this as completed in #245

sindresorhus pushed a commit that referenced this issue


          Put hash right before the last file extension (#245)

de0537f

Fixes #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment