New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize `@file-type/xml` for XML type determination #40

Open

Borewit wants to merge 1 commit into sindresorhus:main from Borewit:utilize-file-type-xml

Borewit commented Dec 20, 2024 •

edited

Loading

Use @file-type/xml for XML type determination.

This has a few advantages:

Will use namespace, if the XML source file does support namespace
Is faster on larger SVG files (903 ms processing Propane_flame_contours-en.svg versus 1428 ms). If validation would not be required (or disabled) the determination could be brought back to 29 ms.
Smaller dependency footprint

I was just curious I can could pass the unit tests with @file-type/xml.


          Utilize @file-type/xml for XML type determination

8ee0093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet